Repository navigation
fix: intword decillion to googol gap returns 0.0 googol - #454
Closed
agbesiprincekwabena-cmd wants to merge 4 commits into
Closed
agbesiprincekwabena-cmd wants to merge 4 commits into
agbesiprincekwabena-cmd wants to merge 4 commits into
Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
==========================================
- Coverage 99.69% 93.28% -6.42%
==========================================
Files 12 12
Lines 996 998 +2
==========================================
- Hits 993 931 -62
- Misses 3 67 +64
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
CI fails. Duplicate of #415. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #356 and #86
Problem
powersjumps from 1033 (decillion) to 10100 (googol) - gap is 10**67, not 1000.Old check
format % chopped == 1000caused:Solution
Compare to actual gap:
powers[ordinal] // powers[ordinal-1]Before:
intword(10**36) = '0.0 googol'
After:
intword(1036) = '1000.0 decillion'
intword(1033 + 81//10) = plain number (gap fix)
Tests: 44 intword tests passed